Revert "refactor(WS): 使用连接池上下文管理器简化连接管理"

This reverts commit c851b49db9.

core/ws_pool.py

@@ -7,10 +7,9 @@ WebSocket 连接池模块
 import asyncio
 import websockets
 from websockets.legacy.client import WebSocketClientProtocol
-from typing import Optional, Dict, Any, cast, Union, AsyncGenerator
+from typing import Optional, Dict, Any, cast, Union
 import uuid
 from loguru import logger
-import contextlib
 
 from .config_loader import global_config
 from .utils.exceptions import WebSocketError, WebSocketConnectionError
@@ -65,11 +64,9 @@ class WSConnection:
         if not self.is_active:
             return False
         try:
-            # 使用 wait_for 包装 ping
-            pong_waiter = await self.conn.ping()
-            await asyncio.wait_for(pong_waiter, timeout=timeout)
+            await asyncio.wait_for(self.conn.ping(), timeout=timeout)
             return True
-        except (asyncio.TimeoutError, websockets.exceptions.ConnectionClosed, Exception):
+        except (asyncio.TimeoutError, websockets.exceptions.ConnectionClosed):
             self.is_active = False
             return False
 
@@ -79,10 +76,7 @@ class WSConnection:
         """
         if self.is_active:
             self.is_active = False
-            try:
-                await self.conn.close()
-            except Exception:
-                pass
+            await self.conn.close()
 
 
 class WSConnectionPool:
@@ -103,8 +97,6 @@ class WSConnectionPool:
         self.pool: asyncio.Queue[WSConnection] = asyncio.Queue(maxsize=pool_size)
         self._closed = False
         self._cleanup_task: Optional[asyncio.Task] = None
-        self._current_size = 0  # 当前管理的连接数（包括池中和借出的）
-        self._lock = asyncio.Lock() # 用于保护 _current_size 的修改
         
         # 从全局配置读取参数
         self.url = global_config.napcat_ws.uri
@@ -123,17 +115,14 @@ class WSConnectionPool:
         # 启动连接清理任务
         self._cleanup_task = asyncio.create_task(self._cleanup_idle_connections())
         
-        # 预热连接池
+        # 创建初始连接
         for _ in range(self.pool_size):
             try:
                 conn = await self._create_connection()
                 await self.pool.put(conn)
-                async with self._lock:
-                    self._current_size += 1
                 logger.info(f"WebSocket 连接 {conn.conn_id} 已创建并加入连接池")
             except Exception as e:
                 logger.error(f"创建初始连接失败: {e}")
-                # 初始连接失败不抛出异常，允许后续动态创建
     
     async def _create_connection(self) -> WSConnection:
         """
@@ -154,17 +143,6 @@ class WSConnectionPool:
         except Exception as e:
             raise WebSocketConnectionError(f"创建 WebSocket 连接失败: {e}")
     
-    @contextlib.asynccontextmanager
-    async def connection(self) -> AsyncGenerator[WSConnection, None]:
-        """
-        获取连接的上下文管理器
-        """
-        conn = await self.get_connection()
-        try:
-            yield conn
-        finally:
-            await self.release_connection(conn)
-
     async def get_connection(self) -> WSConnection:
         """
         从连接池获取一个健康的连接，包含健康检查。
@@ -172,64 +150,25 @@ class WSConnectionPool:
         if self._closed:
             raise WebSocketError("连接池已关闭")
         
-        start_time = asyncio.get_event_loop().time()
-        timeout = 10  # 获取连接的总超时时间
+        try:
+            # 尝试从连接池获取连接
+            conn = await asyncio.wait_for(self.pool.get(), timeout=5)
+            
+            # 健康检查
+            if await conn.ping():
+                logger.debug(f"连接 {conn.conn_id} 健康检查通过")
+                return conn
+            else:
+                logger.warning(f"连接 {conn.conn_id} 健康检查失败，丢弃并获取新连接")
+                await conn.close()
+                return await self.get_connection() # 递归获取下一个
 
-        while True:
-            if asyncio.get_event_loop().time() - start_time > timeout:
-                raise WebSocketError("获取连接超时")
-
-            try:
-                # 1. 尝试从池中获取
-                conn = self.pool.get_nowait()
-                
-                # 健康检查
-                if await conn.ping():
-                    logger.debug(f"连接 {conn.conn_id} 健康检查通过")
-                    return conn
-                else:
-                    logger.warning(f"连接 {conn.conn_id} 健康检查失败，丢弃")
-                    await conn.close()
-                    async with self._lock:
-                        self._current_size -= 1
-                    # 继续循环，尝试获取下一个或创建新的
-                    continue
-
-            except asyncio.QueueEmpty:
-                # 池为空，检查是否可以创建新连接
-                async with self._lock:
-                    if self._current_size < self.pool_size:
-                        # 有配额，创建新连接
-                        self._current_size += 1 # 先占位
-                        create_new = True
-                    else:
-                        create_new = False
-                
-                if create_new:
-                    try:
-                        conn = await self._create_connection()
-                        return conn
-                    except Exception as e:
-                        async with self._lock:
-                            self._current_size -= 1 # 回滚占位
-                        logger.error(f"创建新连接失败: {e}")
-                        await asyncio.sleep(1) # 避免快速失败循环
-                        continue
-                else:
-                    # 没有配额，等待池中有可用连接
-                    try:
-                        conn = await asyncio.wait_for(self.pool.get(), timeout=1.0)
-                        # 获取到了，进行健康检查（在下一次循环中处理，或者这里直接处理）
-                        # 为了代码复用，我们把 conn 放回去（或者直接用），这里直接用
-                        if await conn.ping():
-                            return conn
-                        else:
-                            await conn.close()
-                            async with self._lock:
-                                self._current_size -= 1
-                            continue
-                    except asyncio.TimeoutError:
-                        continue
+        except asyncio.TimeoutError:
+            # 连接池为空，创建新连接
+            logger.warning("连接池在5秒内无可用连接，创建新连接")
+            return await self._create_connection()
+        except Exception as e:
+            raise WebSocketError(f"获取连接时发生未知错误: {e}")
     
     async def release_connection(self, conn: WSConnection):
         """
@@ -241,26 +180,19 @@ class WSConnectionPool:
         
         if not conn.is_active:
             logger.warning(f"连接 {conn.conn_id} 已失效，不返回连接池")
-            await conn.close()
-            async with self._lock:
-                self._current_size -= 1
             return
         
         try:
-            # 尝试放回池中
-            self.pool.put_nowait(conn)
-            logger.debug(f"连接 {conn.conn_id} 已返回连接池")
-        except asyncio.QueueFull:
-            # 理论上不应该发生，除非 _current_size 逻辑有误
-            logger.warning(f"连接池已满，关闭多余连接 {conn.conn_id}")
-            await conn.close()
-            async with self._lock:
-                self._current_size -= 1
+            if self.pool.full():
+                # 连接池已满，关闭该连接
+                await conn.close()
+                logger.info(f"连接池已满，关闭连接 {conn.conn_id}")
+            else:
+                await self.pool.put(conn)
+                logger.debug(f"连接 {conn.conn_id} 已返回连接池")
         except Exception as e:
             logger.error(f"释放连接失败: {e}")
             await conn.close()
-            async with self._lock:
-                self._current_size -= 1
     
     async def _cleanup_idle_connections(self):
         """
@@ -270,33 +202,23 @@ class WSConnectionPool:
             await asyncio.sleep(60)  # 每分钟检查一次
             
             try:
-                # 我们不替换队列，而是取出检查再放回
-                # 这样比较安全，但可能会暂时清空池子
-                # 更好的做法是只检查队头的连接
+                # 检查连接池中的连接
+                new_pool = asyncio.Queue(maxsize=self.pool_size)
+                current_time = asyncio.get_event_loop().time()
                 
-                # 获取当前队列大小
-                qsize = self.pool.qsize()
-                for _ in range(qsize):
-                    try:
-                        conn = self.pool.get_nowait()
-                    except asyncio.QueueEmpty:
-                        break
+                while not self.pool.empty():
+                    conn = await self.pool.get()
                     
-                    current_time = asyncio.get_event_loop().time()
                     if current_time - conn.last_used > self.max_idle_time:
-                        logger.info(f"清理空闲连接 {conn.conn_id}")
+                        # 连接空闲时间过长，关闭
                         await conn.close()
-                        async with self._lock:
-                            self._current_size -= 1
+                        logger.info(f"清理空闲连接 {conn.conn_id}")
                     else:
-                        # 还没过期，放回去
-                        try:
-                            self.pool.put_nowait(conn)
-                        except asyncio.QueueFull:
-                            # 竞争条件下可能满了
-                            await conn.close()
-                            async with self._lock:
-                                self._current_size -= 1
+                        # 放回新队列
+                        await new_pool.put(conn)
+                
+                # 替换原连接池
+                self.pool = new_pool
             except Exception as e:
                 logger.error(f"清理空闲连接失败: {e}")
     
@@ -319,10 +241,7 @@ class WSConnectionPool:
         
         # 关闭所有连接
         while not self.pool.empty():
-            try:
-                conn = self.pool.get_nowait()
-                await conn.close()
-            except asyncio.QueueEmpty:
-                break
+            conn = await self.pool.get()
+            await conn.close()
         
-        logger.info("WebSocket 连接池已关闭")
+        logger.info("WebSocket 连接池已关闭")